Add deprecation warning for column grid classes and add container-sm utility class #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbot
reviewed
Jan 25, 2019
Co-Authored-By: jonrohan <rohan@github.com>
shawnbot
force-pushed
the
release-11.0.0
branch
from
a7a0780
to
7860079
Compare
This was referenced Dec 20, 2022
This was referenced Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a deprecation warning for our old column classes. They will be removed in v12.
We recommend using the grid classes in https://styleguide.github.com/primer/objects/grid/
--
I've also noticed we don't have
container-smutility class which is in github/github. Moving to primer so we can cleanup there.@shawnbot